Detect missing error messages (#781)

spicelang · Feb 15, 2025 · c2f93e9 · c2f93e9
1 parent b40111a
commit c2f93e9
Show file tree

Hide file tree

Showing 7 changed files with 17 additions and 6 deletions.
diff --git a/src/exception/CliError.cpp b/src/exception/CliError.cpp
@@ -2,6 +2,8 @@
 
 #include "CliError.h"
 
+#include <util/GlobalDefinitions.h>
+
 namespace spice::compiler {
 
 /**
@@ -44,7 +46,8 @@ std::string CliError::getMessagePrefix(CliErrorType errorType) {
   case COMING_SOON_CLI:
     return "Coming soon";
   }
-  return "Unknown error";
+  assert_fail("Unknown error"); // GCOV_EXCL_LINE
+  return "Unknown error";       // GCOV_EXCL_LINE
 }
 
 } // namespace spice::compiler
diff --git a/src/exception/CompilerError.cpp b/src/exception/CompilerError.cpp
@@ -60,7 +60,8 @@ std::string CompilerError::getMessagePrefix(CompilerErrorType errorType) {
   case INVALID_MODULE:         // LCOV_EXCL_LINE
     return "Invalid module";   // LCOV_EXCL_LINE
   }
-  return "Unknown error"; // GCOV_EXCL_LINE
+  assert_fail("Unknown error"); // GCOV_EXCL_LINE
+  return "Unknown error";       // GCOV_EXCL_LINE
 }
 
 } // namespace spice::compiler
diff --git a/src/exception/LexerError.cpp b/src/exception/LexerError.cpp
@@ -35,6 +35,7 @@ std::string LexerError::getMessagePrefix(LexerErrorType errorType) {
   case TOKENIZING_FAILED:
     return "Tokenizing failed";
   }
+  assert_fail("Unknown error"); // GCOV_EXCL_LINE
   return "Unknown error"; // GCOV_EXCL_LINE
 }
 

diff --git a/src/exception/LinkerError.cpp b/src/exception/LinkerError.cpp
@@ -2,6 +2,8 @@
 
 #include "LinkerError.h"
 
+#include <util/GlobalDefinitions.h>
+
 namespace spice::compiler {
 
 /**
@@ -32,7 +34,8 @@ std::string LinkerError::getMessagePrefix(LinkerErrorType errorType) {
   case LINKER_ERROR:
     return "Linker error occurred";
   }
-  return "Unknown error"; // GCOV_EXCL_LINE
+  assert_fail("Unknown error"); // GCOV_EXCL_LINE
+  return "Unknown error";       // GCOV_EXCL_LINE
 }
 
 } // namespace spice::compiler
diff --git a/src/exception/ParserError.cpp b/src/exception/ParserError.cpp
@@ -45,7 +45,8 @@ std::string ParserError::getMessagePrefix(ParserErrorType errorType) {
   case RESERVED_KEYWORD:
     return "Usage of reserved keyword";
   }
-  return "Unknown error"; // GCOV_EXCL_LINE
+  assert_fail("Unknown error"); // GCOV_EXCL_LINE
+  return "Unknown error";       // GCOV_EXCL_LINE
 }
 
 } // namespace spice::compiler
diff --git a/src/exception/SemanticError.cpp b/src/exception/SemanticError.cpp
@@ -239,7 +239,8 @@ std::string SemanticError::getMessagePrefix(SemanticErrorType errorType) {
   case COMING_SOON_SA:
     return "Coming soon";
   }
-  return "Unknown error"; // GCOV_EXCL_LINE
+  assert_fail("Unknown error"); // GCOV_EXCL_LINE
+  return "Unknown error";       // GCOV_EXCL_LINE
 }
 
 } // namespace spice::compiler
diff --git a/src/util/CompilerWarning.cpp b/src/util/CompilerWarning.cpp
@@ -79,7 +79,8 @@ std::string CompilerWarning::getMessagePrefix(CompilerWarningType warningType) {
   case VERIFIER_DISABLED:
     return "Verifier disabled";
   }
-  return "Unknown warning"; // GCOV_EXCL_LINE
+  assert_fail("Unknown warning"); // GCOV_EXCL_LINE
+  return "Unknown warning";       // GCOV_EXCL_LINE
 }
 
 } // namespace spice::compiler