Do not generate unnecessary allocas for logical and bitwise not opera…

…tors (#714)
spicelang · Jan 18, 2025 · 0a5692d · 0a5692d
1 parent c739d58
commit 0a5692d
Show file tree

Hide file tree

Showing 4 changed files with 256 additions and 280 deletions.
diff --git a/src/irgenerator/GenExpressions.cpp b/src/irgenerator/GenExpressions.cpp
@@ -660,12 +660,6 @@ std::any IRGenerator::visitPrefixUnaryExpr(const PrefixUnaryExprNode *node) {
     // Execute operation
     lhs = conversionManager.getPrefixNotInst(node, lhs, lhsSTy);
 
-    // This operator can not work in-place, so we need additional memory
-    lhs.ptr = insertAlloca(lhs.value->getType());
-
-    // Store the new value
-    insertStore(lhs.value, lhs.ptr, lhs.entry && lhs.entry->isVolatile);
-
     break;
   }
   case PrefixUnaryExprNode::OP_BITWISE_NOT: {
@@ -675,12 +669,6 @@ std::any IRGenerator::visitPrefixUnaryExpr(const PrefixUnaryExprNode *node) {
     // Execute operation
     lhs = conversionManager.getPrefixBitwiseNotInst(node, lhs, lhsSTy);
 
-    // This operator can not work in-place, so we need additional memory
-    lhs.ptr = insertAlloca(lhs.value->getType());
-
-    // Store the new value
-    insertStore(lhs.value, lhs.ptr, lhs.entry && lhs.entry->isVolatile);
-
     break;
   }
   case PrefixUnaryExprNode::OP_DEREFERENCE: {