Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add app-name for KDE Plasma notifications #403

Closed
sonic2kk opened this issue Jan 24, 2022 · 4 comments · Fixed by #404
Closed

Add app-name for KDE Plasma notifications #403

sonic2kk opened this issue Jan 24, 2022 · 4 comments · Fixed by #404

Comments

@sonic2kk
Copy link
Owner

SteamTinkerLaunch notifications on KDE Plasma display the process as "notify-send". It would be nicer if it said "SteamTinkerLaunch" as it's more in line with what a user would expect. Below is a small example of a notification I was able to trigger on my system, though for what it's worth, most applications do not display this name correctly on KDE Plasma and the only one I can actually think of that properly displays its process name is Firefox (as just "Firefox" or "Firefox Developer Edition", etc).

Screenshot_20220124_211008

I took a look into how this might be implemented and I'm not sure exactly how this is done. It seems like this information can be taken in from a "desktop" file. An example I was testing was notify-send foo bar -h STRING:desktop-entry:steamtinkerlaunch, which still displays "notify-send" as the process name, but will display the steamtinkerlaunch icon, which does not normally happen with SteamTinkerLaunch notifications at all either (and may not be desired behaviour, either).

It is very much just a "nice to have" feature but would add extra clarity as to where notifications are coming from for users.

@zany130
Copy link
Collaborator

zany130 commented Jan 24, 2022

this is what /~https://github.com/frostworx/steamtinkerlaunch/wiki/Notifier is trying to address. I guess you would want to use the native KDE notifier program instead of the generic notify-send that would allow better integration on KDE. You can in theory do read the linked wiki page but never really bothered to get it working. I just remember someone asking for that feature in the old discord and then the feature being implemented

if you figure it out though please do post how you did it for others and it could maybe even be contributed to the wiki page as an example on how to use that option in KDE

@sonic2kk
Copy link
Owner Author

sonic2kk commented Jan 24, 2022

Thanks! I'll give the wiki a read, apologies for not investigating the wiki more thoroughly.

It seems adding the -a SteamTinkerLaunch flag sets the application name, at least in my tests with using notify-send to send test notifications. I will test with SteamTinkerLaunch now and see how I get on, and if it works, I'll see about contributing to the wiki! 😄

@sonic2kk
Copy link
Owner Author

sonic2kk commented Jan 24, 2022

Well that was much easier than expected. Simply updating the line for the Notifier in the Global Menu settings with -a SteamTinkerLaunch seems to correctly set the title, resolving my issue.

Would most Linux distributions support this flag? It is not mentioned in the manual pages for my distro, I found it on this page. Is notify-send implemented differently across distros? If not, and this is desireable behaviour, this additional argument could be added to the notifier arguments.

@sonic2kk sonic2kk changed the title Add process title for KDE Plasma notifications Add app-name for KDE Plasma notifications Jan 24, 2022
@frostworx
Copy link
Collaborator

thanks for the PR @sonic2kk
and thanks for helping here @zany130
very appreciated! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants