Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: include rule name as comment #16

Merged
merged 3 commits into from
Jan 10, 2024
Merged

feat: include rule name as comment #16

merged 3 commits into from
Jan 10, 2024

Conversation

fgvieira
Copy link
Contributor

@fgvieira fgvieira commented Jan 10, 2024 •
edited
Loading

Since the jobs are named with a unique ID, it is not easy to figure out what rule is being run on a specific SLURM job.
This PR adds the rule name as a comment, so that it can be displayed by squeue and sacct.

@fgvieira fgvieira requested a review from cmeesters January 10, 2024 12:01
@cmeesters
Copy link
Member

The idea behind slurm_extra is to allow using additional features from sbatch and not to code all explicitly in the executor.

Regarding the jobnames, please see the discussion in #12 and the issue I just opened: #17. If you want to: go ahead on #17 (I will not find the time this week). Yet, adding the comment and other features might be better handled with slurm_extra, don't you think? Otherwise, we possibly end up with a huge number of flags to be supported on both ends and whenever SchedMD decides on a different CLI our code breaks.

@cmeesters cmeesters mentioned this pull request Jan 10, 2024
Merged
@fgvieira
Copy link
Contributor Author

How can I specify a rule-specific comment through slum_extra? Do you think something like --default-resources slurm_extra="--comment {job.name}" work? Or I'd have to specify a slurm_extra on each rule?

@cmeesters
Copy link
Member

You cannot, and as pointed out in #17 I concede.

cmeesters
cmeesters approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@cmeesters cmeesters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea

@cmeesters cmeesters merged commit 2e39b18 into snakemake:main Jan 10, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Jan 10, 2024
Merged
@fgvieira fgvieira deleted the rulename_as_comment branch January 11, 2024 08:25
cmeesters pushed a commit that referenced this pull request Jan 12, 2024
@github-actions
chore(main): release 0.2.0 (#19)
5501144 
🤖 I have created a release *beep* *boop*
---


##
[0.2.0](v0.1.5...v0.2.0)
(2024-01-10)


### Features

* include rule name as comment
([#16](#16))
([2e39b18](2e39b18))

---
This PR was generated with [Release
Please](/~https://github.com/googleapis/release-please). See
[documentation](/~https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@cmeesters cmeesters mentioned this pull request Jan 12, 2024
Closed
@tdido tdido mentioned this pull request Apr 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmeesters cmeesters cmeesters approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fgvieira @cmeesters