Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate snakemake report #80

Merged
merged 11 commits into from
Sep 13, 2024
Merged

feat: generate snakemake report #80

merged 11 commits into from
Sep 13, 2024

Conversation

yeising
Copy link
Collaborator

@yeising yeising commented Aug 30, 2024

No description provided.

@cmeesters
Copy link
Collaborator

is it ready for review?

@yeising yeising marked this pull request as ready for review September 10, 2024 14:56
@@ -44,6 +44,7 @@ rule plot_all_samples:
category="Quality control",
caption="../report/nanoplot_all_samples_report.rst",
),
# This parameter is in line with the Snakemake docs 8.20.3 guideline on how to avoid having parameters as output prefixes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I meant to say: Please indicate a sample string, to which index refers.

You are absolutely right, yet I have reason to fear the day, that I have to maintain this piece and I will need hours to pinpoint the change leading to a difficult to understand traceback.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will merge regardless

@yeising yeising linked an issue Sep 11, 2024 that may be closed by this pull request
@cmeesters cmeesters merged commit cd25504 into main Sep 13, 2024
4 of 5 checks passed
@cmeesters cmeesters deleted the feat-report branch September 13, 2024 07:41
This was referenced Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add report rst files
2 participants