Merge PR #541 (app report fixes) into fixes

src/core/app.lua

@@ -414,15 +414,13 @@ function report_apps ()
          print(name, ("[dead: %s]"):format(app.dead.error))
       elseif app.report then
          print(name)
-         with_restart(app, app.report)
-      end
-   end
-end
-
-function report_each_app ()
-   for i = 1, #app_array do
-      if app_array[i].report then
-         app_array[i]:report()
+         -- Restarts are currently disabled, still we want to not die on
+         -- errors during app reports, thus this workaround:
+         -- with_restart(app, app.report)
+         local status, err = pcall(app.report)
+         if not status then
+            print("Warning: "..name.." threw an error during report: "..err)
+         end
       end
    end
 end

src/program/packetblaster/packetblaster.lua

@@ -48,7 +48,7 @@ function run (args)
    app.configure(c)
    local fn = function ()
                  print("Transmissions (last 1 sec):")
-                 app.report_each_app()
+                 app.report_apps()
               end
    local t = timer.new("report", fn, 1e9, 'repeating')
    timer.activate(t)

src/program/snabbnfv/traffic/traffic.lua

@@ -20,9 +20,9 @@ local long_opts = {
 function run (args)
    local opt = {}
    local benchpackets
-   local linkreportinterval = 60
+   local linkreportinterval = 0
    local loadreportinterval = 1
-   local debugreportinterval = 600
+   local debugreportinterval = 0
    function opt.B (arg) benchpackets = tonumber(arg)      end
    function opt.h (arg) print(short_usage()) main.exit(1) end
    function opt.H (arg) print(long_usage())  main.exit(1) end