disallow to use #region directives

smdn · Dec 10, 2021 · c326059 · c326059
1 parent 3da58df
commit c326059
Show file tree

Hide file tree

Showing 7 changed files with 1 addition and 24 deletions.
diff --git a/src/Smdn.Fundamental.FourCC/Smdn/FourCC.cs b/src/Smdn.Fundamental.FourCC/Smdn/FourCC.cs
@@ -18,7 +18,6 @@ namespace Smdn {
 #pragma warning restore IDE0055
     public static readonly FourCC Empty = new(0);
 
-#region "construction"
     public static FourCC CreateBigEndian(int bigEndianInt)
       => new(bigEndianInt);
 
@@ -90,9 +89,7 @@ private FourCC(int fourcc)
     {
       this.fourcc = fourcc;
     }
-#endregion
 
-#region "conversion"
     public static implicit operator FourCC(string fourccString)
       => new(fourccString);
 
@@ -172,9 +169,6 @@ public override string ToString()
       }
     }
 
-#endregion
-
-#region "comparison"
     public static bool operator ==(FourCC x, FourCC y)
       => x.fourcc == y.fourcc;
 
@@ -201,7 +195,6 @@ public bool Equals(string other)
 
     public bool Equals(byte[] other)
       => (other != null) && other.SequenceEqual(this.ToByteArray());
-#endregion
 
     public override int GetHashCode()
       => fourcc;

diff --git a/src/Smdn.Fundamental.Shell/Smdn.OperatingSystem/ShellString.cs b/src/Smdn.Fundamental.Shell/Smdn.OperatingSystem/ShellString.cs
@@ -61,7 +61,6 @@ public static string Expand(ShellString str)
         return str.Expanded;
     }
 
-#region "equality"
     public bool Equals(ShellString other)
     {
       if (object.ReferenceEquals(this, other))
@@ -109,9 +108,7 @@ public override int GetHashCode()
       else
         return Raw.GetHashCode();
     }
-#endregion
 
-#region "conversion"
     public static explicit operator string(ShellString str)
     {
       if (str == null)
@@ -132,6 +129,5 @@ public override string ToString()
     {
       return Raw;
     }
-#endregion
   }
 }
diff --git a/src/Smdn.Fundamental.Stream/Smdn.IO.Streams/PartialStream.cs b/src/Smdn.Fundamental.Stream/Smdn.IO.Streams/PartialStream.cs
@@ -15,7 +15,6 @@ public class PartialStream :
 #endif
 #pragma warning restore SA1001
   {
-#region "class members"
     public static PartialStream CreateNonNested(Stream innerOrPartialStream, long length)
     {
       return CreateNonNested(innerOrPartialStream, innerOrPartialStream.Position, length, true);
@@ -42,7 +41,6 @@ public static PartialStream CreateNonNested(Stream innerOrPartialStream, long of
         ? new(partialStream.InnerStream, partialStream.offset + offset, length, !partialStream.writable, partialStream.LeaveInnerStreamOpen, seekToBegin)
         : new(innerOrPartialStream, offset, length, true, true, seekToBegin);
     }
-#endregion
 
     public Stream InnerStream {
       get { CheckDisposed(); return stream; }

diff --git a/src/Smdn.Fundamental.UInt24n/Smdn/UInt24.cs b/src/Smdn.Fundamental.UInt24n/Smdn/UInt24.cs
@@ -136,7 +136,6 @@ public UInt32 ToUInt32()
          (UInt32)(Byte1 << 8) |
          (UInt32)Byte2;
 
-#region "IConvertible implementation"
     TypeCode IConvertible.GetTypeCode() => TypeCode.Object;
 
     string IConvertible.ToString(IFormatProvider provider) => ToString(null, provider);
@@ -161,7 +160,6 @@ public UInt32 ToUInt32()
 
     object IConvertible.ToType(Type conversionType, IFormatProvider provider)
       => Convert.ChangeType(ToUInt32(), conversionType, provider);
-#endregion
 
     public int CompareTo(object obj)
     {

diff --git a/src/Smdn.Fundamental.UInt24n/Smdn/UInt48.cs b/src/Smdn.Fundamental.UInt24n/Smdn/UInt48.cs
@@ -160,7 +160,6 @@ public UInt64 ToUInt64()
          (UInt64)((UInt64)Byte4 <<  8) |
          (UInt64)Byte5;
 
-#region "IConvertible implementation"
     TypeCode IConvertible.GetTypeCode()
     {
       return TypeCode.Object;
@@ -245,7 +244,6 @@ object IConvertible.ToType(Type conversionType, IFormatProvider provider)
     {
       return Convert.ChangeType(ToUInt64(), conversionType, provider);
     }
-#endregion
 
     public int CompareTo(object obj)
     {

diff --git a/src/Smdn.Fundamental.Uuid/Smdn/Uuid.cs b/src/Smdn.Fundamental.Uuid/Smdn/Uuid.cs
@@ -731,7 +731,6 @@ public Uuid(string uuid)
 #endif
     }
 
-    #region "comparison"
     public static bool operator <(Uuid x, Uuid y) => x.CompareTo(y) < 0;
     public static bool operator <=(Uuid x, Uuid y) => x.CompareTo(y) <= 0;
     public static bool operator >(Uuid x, Uuid y) => y < x;
@@ -786,9 +785,7 @@ public int CompareTo(Uuid other)
 
       return 0;
     }
-    #endregion
 
-    #region "equality"
     public static bool operator ==(Uuid x, Uuid y) => x.fields_high == y.fields_high && x.fields_low == y.fields_low;
     public static bool operator !=(Uuid x, Uuid y) => x.fields_high != y.fields_high || x.fields_low != y.fields_low;
 
@@ -804,9 +801,7 @@ public override bool Equals(object obj)
 
     public bool Equals(Guid other) => this == (Uuid)other;
     public bool Equals(Uuid other) => this == other;
-    #endregion
 
-    #region "conversion"
     public static explicit operator Guid(Uuid @value) => @value.ToGuid();
 
     public static explicit operator Uuid(Guid @value) => new(@value);
@@ -858,7 +853,6 @@ public byte[] ToByteArray(bool asBigEndian)
 
       return bytes;
     }
-    #endregion
 
     public override int GetHashCode()
       => fields_high.GetHashCode() ^ fields_low.GetHashCode();

diff --git a/src/StyleCop.Analyzers.ruleset b/src/StyleCop.Analyzers.ruleset
@@ -63,7 +63,7 @@
     <Rule Id="SA1121"  Action="Warning" />          <!-- Use built-in type alias -->
     <Rule Id="SA1122"  Action="Warning" />          <!-- Use string.Empty for empty strings -->
     <Rule Id="SA1123"  Action="Warning" />          <!-- Do not place regions within elements -->
-    <Rule Id="SA1124"  Action="None" />             <!-- Do not use regions -->
+    <Rule Id="SA1124"  Action="Warning" />          <!-- Do not use regions -->
     <Rule Id="SA1125"  Action="Warning" />          <!-- Use shorthand for nullable types -->
     <Rule Id="SA1126"  Action="None" />             <!-- Prefix calls correctly -->
     <Rule Id="SA1127"  Action="None" />             <!-- Generic type constraints should be on their own line -->