Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix automatic overhang threshold #2098

Closed
wants to merge 1 commit into from
Closed

Conversation

hyperair
Copy link
Contributor

We should be supporting perimeters that are overhung further than half a
perimeter out, rather than two times the perimeter width.

Fixes: #2068

@curiouspl2
Copy link

+1

We should be supporting perimeters that are overhung further than half a
perimeter out, rather than two times the perimeter width.

Fixes: slic3r#2068
@lordofhyphens
Copy link
Member

@hyperair How does this work with the default spacing (which is one support width from the model) for support?

@hyperair
Copy link
Contributor Author

I remember it working fine -- the only thing it changed was whether or not some things got supported. But I got tired of keeping track of the diff, so I stopped using it altogether.

@bubnikv
Copy link
Contributor

bubnikv commented Oct 10, 2016

I believe this fix is correct, though I may be wrong and I don't understand the reasoning of @alexrj.

@lordofhyphens
Copy link
Member

@hyperair could you make the width overhang (relative to perimeter width) configurable instead with a default of 0.5?

@lordofhyphens
Copy link
Member

I extended it in #3752. Closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic threshold setting fails to create support when needed
4 participants