Skip to content

Commit

Permalink
Improve monospaced font on Chrome Android
Browse files Browse the repository at this point in the history
See explanation in primer/css#812
  • Loading branch information
sindresorhus committed Dec 23, 2019
1 parent 6d5695a commit c204a08
Show file tree
Hide file tree
Showing 7 changed files with 6 additions and 7 deletions.
1 change: 0 additions & 1 deletion modern-normalize.css
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,6 @@ pre {
Consolas,
'Liberation Mono',
Menlo,
Courier,
monospace; /* 1 */
font-size: 1em; /* 2 */
}
Expand Down
2 changes: 1 addition & 1 deletion test/acceptance/chrome/rules.ts
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ test('Add the correct font weight in Chrome, Edge, and Safari.', async t => {

test('Improve consistency of default fonts in all browsers.', async t => {
await t
.expect(Selector('[data-test--code]').getStyleProperty('font-family')).eql('SFMono-Regular, Consolas, "Liberation Mono", Menlo, Courier, monospace');
.expect(Selector('[data-test--code]').getStyleProperty('font-family')).eql('SFMono-Regular, Consolas, "Liberation Mono", Menlo, monospace');
});

test('Correct the odd `em` font sizing in all browsers.', async t => {
Expand Down
2 changes: 1 addition & 1 deletion test/acceptance/chrome/validation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ test('Add the correct font weight in Chrome, Edge, and Safari.', async t => {

test('Improve consistency of default fonts in all browsers.', async t => {
await t
.expect(Selector('[data-test--code]').getStyleProperty('font-family')).notEql('SFMono-Regular, Consolas, "Liberation Mono", Menlo, Courier, monospace');
.expect(Selector('[data-test--code]').getStyleProperty('font-family')).notEql('SFMono-Regular, Consolas, "Liberation Mono", Menlo, monospace');
});

test('Correct the odd `em` font sizing in all browsers.', async t => {
Expand Down
2 changes: 1 addition & 1 deletion test/acceptance/firefox/rules.ts
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ test('Add the correct font weight in Chrome, Edge, and Safari.', async t => {

test('Improve consistency of default fonts in all browsers.', async t => {
await t
.expect(Selector('[data-test--code]').getStyleProperty('font-family')).eql('SFMono-Regular, Consolas, "Liberation Mono", Menlo, Courier, monospace');
.expect(Selector('[data-test--code]').getStyleProperty('font-family')).eql('SFMono-Regular, Consolas, "Liberation Mono", Menlo, monospace');
});

test('Correct the odd `em` font sizing in all browsers.', async t => {
Expand Down
2 changes: 1 addition & 1 deletion test/acceptance/firefox/validation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ test('Add the correct font weight in Chrome, Edge, and Safari.', async t => {

test('Improve consistency of default fonts in all browsers.', async t => {
await t
.expect(Selector('[data-test--code]').getStyleProperty('font-family')).notEql('SFMono-Regular, Consolas, "Liberation Mono", Menlo, Courier, monospace');
.expect(Selector('[data-test--code]').getStyleProperty('font-family')).notEql('SFMono-Regular, Consolas, "Liberation Mono", Menlo, monospace');
});

test('Correct the odd `em` font sizing in all browsers.', async t => {
Expand Down
2 changes: 1 addition & 1 deletion test/acceptance/safari/rules.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ test('Add the correct font weight in Chrome, Edge, and Safari.', async t => {

test('Improve consistency of default fonts in all browsers.', async t => {
await t
.expect(Selector('[data-test--code]').getStyleProperty('font-family')).eql('SFMono-Regular, Consolas, "Liberation Mono", Menlo, Courier, monospace');
.expect(Selector('[data-test--code]').getStyleProperty('font-family')).eql('SFMono-Regular, Consolas, "Liberation Mono", Menlo, monospace');
});

test('Correct the odd `em` font sizing in all browsers.', async t => {
Expand Down
2 changes: 1 addition & 1 deletion test/acceptance/safari/validation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ test('Add the correct font weight in Chrome, Edge, and Safari.', async t => {

test('Improve consistency of default fonts in all browsers.', async t => {
await t
.expect(Selector('[data-test--code]').getStyleProperty('font-family')).notEql('SFMono-Regular, Consolas, "Liberation Mono", Menlo, Courier, monospace');
.expect(Selector('[data-test--code]').getStyleProperty('font-family')).notEql('SFMono-Regular, Consolas, "Liberation Mono", Menlo, monospace');
});

test('Correct the odd `em` font sizing in all browsers.', async t => {
Expand Down

0 comments on commit c204a08

Please sign in to comment.