Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMS 6 - Enforce minimum version of egulias dep #11441

Closed
1 task
emteknetnz opened this issue Oct 22, 2024 · 3 comments
Closed
1 task

CMS 6 - Enforce minimum version of egulias dep #11441

emteknetnz opened this issue Oct 22, 2024 · 3 comments

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Oct 22, 2024

We are getting literally thousands of deprecation notices on --prefer-lowest builds e.g. /~https://github.com/silverstripe/recipe-core/actions/runs/11468619556/job/31914133348

PHP Deprecated: Function utf8_encode() is deprecated in /home/runner/work/recipe-core/recipe-core/vendor/egulias/email-validator/src/EmailLexer.php on line 275

Notes

Acceptance criteria

  • Prefer lowest builds install a version of the egulias dep that does not trigger deprecation notice, either through "require" or "conflict", whichever makes the most sense

PR

@emteknetnz emteknetnz transferred this issue from silverstripe/silverstripe-iframe Oct 22, 2024
@GuySartorelli
Copy link
Member

I think there used to be a conflict that I probably thought "we can't possibly need that anymore" 😅 I wish we could add comments to composer.json.
We should probably add it as an explicit dependency.

@GuySartorelli
Copy link
Member

PR merged

@emteknetnz
Copy link
Member Author

Notice no longer showing in recipe-core prefer-lowest build /~https://github.com/silverstripe/recipe-core/actions/runs/12801164795/job/35690194769

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants