Verify tlog entries using the Rekor public keys from TUF #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typical verification used VerifyBundle, which called GetRekorKeys, which fetches keys from the TUF repo. If the bundle was not present or for a specific error when a duplicate log entry was present, then the tlog entry would be verified using a public key fetched from Rekor's API. This key was not verified using TUF metadata. This change simply removes the API call and uses Rekor public keys from the TUF repo. Tested locally by not including the Rekor bundle in the OCI signature, which will hit the code path to fetch the entry from the log. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
|
cc @asraa |
dlorenc
approved these changes
Feb 15, 2022
asraa
approved these changes
Feb 16, 2022
|
Merged in another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typical verification used VerifyBundle, which called
GetRekorKeys, which fetches keys from the TUF repo.
If the bundle was not present or for a specific error
when a duplicate log entry was present, then the tlog
entry would be verified using a public key fetched from
Rekor's API. This key was not verified using TUF metadata.
This change simply removes the API call and uses Rekor
public keys from the TUF repo.
Tested locally by not including the Rekor bundle in
the OCI signature, which will hit the code path to
fetch the entry from the log.
Signed-off-by: Hayden Blauzvern hblauzvern@google.com
Summary
Ticket Link
Fixes
Release Note