Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine: Remove one clone on assets_prefix #270

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

TieWay59
Copy link
Contributor

@TieWay59 TieWay59 commented Oct 2, 2023

This clone is not consist with the usage of assets_prefix in following
code and it's unnecessary.

ref:

if let Some(name) = req_path.strip_prefix(&self.assets_prefix) {

.replace("__ASSETS_PREFIX__", &self.assets_prefix)

Signed-off-by: TieWay59 tieway59@foxmail.com

This clone is not consist with the usage of `assets_prefix` in following
code and it's unnecessary.

Signed-off-by: TieWay59 <tieway59@foxmail.com>
@sigoden sigoden merged commit 53c9bc8 into sigoden:main Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants