Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System endianness bug affecting nanonext 0.9.2 #14

Closed
shikokuchuo opened this issue Aug 17, 2023 · 1 comment
Closed

System endianness bug affecting nanonext 0.9.2 #14

shikokuchuo opened this issue Aug 17, 2023 · 1 comment

Comments

@shikokuchuo
Copy link
Owner

nanonext 0.9.2 brought performance enhancements to serialisation / unserialisation by moving this to a lower level.

Part of the gains was to allow use of system endianness for serialisation, which is fine as unserialisation can automatically account for this. So this is not an issue even for sending/receiving between systems with different endianness.

However the same underlying functions were adopted by the sha / base64 functions, which is now problematic as the output will differ depending on system endianness.

@shikokuchuo
Copy link
Owner Author

shikokuchuo commented Aug 17, 2023

The above commit will fix this issue for all releases > 0.9.2, by always using big endian.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant