test/cqlpy: add regression test for tombstone_gc in "desc table" #22354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The small cqlpy test in this patch is a regression test for issue scylladb#14390, which claimed that the Scylla-only "tombstone_gc" option is missing from the output of "describe table". This test shows that this report is *not* true, at least not when the "server-side describe" is used. "test/cqlpy/run --release ..." shows that this test passes on master and also for Scylla versions all the way back to Scylla 5.2 (Scylla 5.1 did not support server-side describe, so the test fails for that reason). This suggests that the report in issue scylladb#14390 was for old-style client-side (cqlsh) describe, which we no longer support, so this issue can be closed. Fixes scylladb#14390. Signed-off-by: Nadav Har'El <nyh@scylladb.com>
dawmd
approved these changes
Jan 16, 2025
| desc = cql.execute(f"DESCRIBE TABLE {table} WITH INTERNALS").one() | ||
| # ignore spaces in comparison, as different versions of Scylla | ||
| # add spaces in different places | ||
| assert with_clause.replace(' ','') in desc.create_statement.replace(' ','') |
There was a problem hiding this comment.
This could potentially be problematic if a new option whose suffix is tombstone_gc were introduced, but for it to be an issue, it would also have to use the same parameters, so all in all it's unlikely to ever happen. Looks good.
There was a problem hiding this comment.
Yes, considering that I'm looking for a very long string (tombstone_gc = {'mode': 'timeout', 'propagation_delay_in_seconds': '73'}) there is no way it will match some other part of the "desc table" because of some unlucky coincidence. This is why I wanted to write this test as short as possible (just 5 lines) and not start to develop sophisticated text-processing machinary around it.
🟢 CI State: SUCCESS✅ - Build Build Details:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The small cqlpy test in this patch is a regression test for issue #14390, which claimed that the Scylla-only "tombstone_gc" option is missing from the output of "describe table".
This test shows that this report is not true, at least not when the "server-side describe" is used. "test/cqlpy/run --release ..." shows that this test passes on master and also for Scylla versions all the way back to Scylla 5.2 (Scylla 5.1 did not support server-side describe, so the test fails for that reason).
This suggests that the report in issue #14390 was for old-style client-side (cqlsh) describe, which we no longer support, so this issue can be closed.
Fixes #14390.