test/cqlpy/run: fix regression in "--release" option #22350
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way that the "test/cqlpy/run --release" feature runs older Scylla releases is that it takes *today*'s command line parameters and "fixes" it to conform to what old releases took. This approach was easy to implement (and the resulting "--release" feature is super useful), but the downside is that we need to update this fixup code whenever we add new options to the Scylla command line used by test/cqlpy/run.py. Commit d04f376 made test/cqlpy/run.py use a new option "--experimental-features=views-with-tablets", so now we need to remove it when running older versions of Scylla. So this is what we do in this patch. Fixes scylladb#22349 Signed-off-by: Nadav Har'El <nyh@scylladb.com>
github-actions
bot
added
the
area/test
🟢 CI State: SUCCESS✅ - Build Build Details:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way that the "test/cqlpy/run --release" feature runs older Scylla releases is that it takes today's command line parameters and "fixes" it to conform to what old releases took. This approach was easy to implement (and the resulting "--release" feature is super useful), but the downside is that we need to update this fixup code whenever we add new options to the Scylla command line used by test/cqlpy/run.py.
Commit d04f376 made test/cqlpy/run.py use a new option "--experimental-features=views-with-tablets", so now we need to remove it when running older versions of Scylla. So this is what we do in this patch.
Fixes #22349