Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keypad shuffle quick-setting plugin #6

Closed
samcday opened this issue May 23, 2024 · 7 comments · Fixed by #58
Closed

Keypad shuffle quick-setting plugin #6

samcday opened this issue May 23, 2024 · 7 comments · Fixed by #58
Labels
needs-upstream-changes Changes to libphosh are required
Milestone

Comments

@samcday
Copy link
Owner

samcday commented May 23, 2024

https://phosh.mobi/posts/custom-plugins-dev/

Idea: add a toggle to switch keypad shuffle on/off

@samcday samcday changed the title Experiment with lockscreen widget plugins Keypad shuffle quick-setting plugin May 24, 2024
@samcday
Copy link
Owner Author

samcday commented May 24, 2024

I think it should be possible to construct a QuickSettings subclass from phrog and get it noticed in the plugin system without too much effort?

That's what I'm hacking on this evening.

@samcday
Copy link
Owner Author

samcday commented May 25, 2024

Implemented in 8f000e4

@samcday samcday closed this as completed May 25, 2024
@samcday
Copy link
Owner Author

samcday commented Aug 14, 2024

Reopening because this isn't quite done yet. Now that phrog is using upstream libphosh releases, I'm waiting on this MR to land (hopefully in 0.42.x): https://gitlab.gnome.org/World/Phosh/phosh/-/merge_requests/1494

@samcday
Copy link
Owner Author

samcday commented Aug 19, 2024

In the meantime, I could keep the code properly included and built in CI, but gated behind a Cargo feature and excluded from distro packaging.

@samcday
Copy link
Owner Author

samcday commented Aug 30, 2024

I need to get #37 done before this, as it requires a patch that I've opened upstream but hasn't landed yet (and I have no idea if it will, actually...)

@samcday
Copy link
Owner Author

samcday commented Sep 5, 2024

The feature is back in main, behind a cargo feature flag that is only enabled for the static vendored build. It has a basic test that verifies the behaviour and provides a solid bit of footage for #18

The necessary plugin changes in upstream Phosh have landed and will be released in 0.42.0, so I can enable this feature properly soon enough. I'll keep the issue open until then.

@samcday
Copy link
Owner Author

samcday commented Sep 5, 2024

@agx here is a GIF for your viewing pleasure 😅

output

(not sure why the second test case is included in that recording. I only just landed the code that adds a second integration test so obviously something has gone slightly awry 🙃 )

@samcday samcday added the needs-upstream-changes Changes to libphosh are required label Sep 7, 2024
@samcday samcday added this to the v0.42.0 milestone Sep 7, 2024
@samcday samcday mentioned this issue Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-upstream-changes Changes to libphosh are required
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant