Merge pull request #93 from s4u/fix-sonar

fix sonar issues
s4u · Jul 13, 2021 · ddf805c · ddf805c
2 parents 52e0d72 + 5640301
commit ddf805c
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/src/main/java/org/simplify4u/slf4jmock/MDCMock.java b/src/main/java/org/simplify4u/slf4jmock/MDCMock.java
@@ -33,7 +33,7 @@ protected MDCMock() {
     }
 
     private static MDCAdapter initMockProxy() {
-        return (MDCAdapter) Proxy.newProxyInstance(MDCMock.class.getClassLoader(),
+        return (MDCAdapter) Proxy.newProxyInstance(Thread.currentThread().getContextClassLoader(),
                 new Class<?>[]{MDCAdapter.class, ProxyMock.class},
                 new MockInvocationHandler("MDC", () -> mock(MDCAdapter.class, withSettings().stubOnly()))
         );

diff --git a/src/main/java/org/simplify4u/slf4jmock/ProxyMock.java b/src/main/java/org/simplify4u/slf4jmock/ProxyMock.java
@@ -16,8 +16,6 @@
 
 package org.simplify4u.slf4jmock;
 
-import org.slf4j.Logger;
-
 /**
  * Interface to describe proxy for created Logger.
  * <p>
@@ -29,6 +27,9 @@ public interface ProxyMock {
 
     Object getMock();
 
+    /**
+     * reset internal mocks state.
+     */
     void clearMock();
 
     String getMockName();

diff --git a/src/main/java/org/slf4j/impl/StaticLoggerBinder.java b/src/main/java/org/slf4j/impl/StaticLoggerBinder.java
@@ -17,6 +17,9 @@
 
 import org.simplify4u.slf4jmock.LoggerMock;
 
+/**
+ * Implementation of Logger Binder.
+ */
 public class StaticLoggerBinder extends LoggerMock {
 
     private static final StaticLoggerBinder SINGLETON = new StaticLoggerBinder();

diff --git a/src/main/java/org/slf4j/impl/StaticMDCBinder.java b/src/main/java/org/slf4j/impl/StaticMDCBinder.java
@@ -18,6 +18,9 @@
 import org.simplify4u.slf4jmock.MDCMock;
 import org.slf4j.spi.MDCAdapter;
 
+/**
+ * Implementation for MDC Binder
+ */
 public class StaticMDCBinder extends MDCMock {
 
     static final StaticMDCBinder SINGLETON = new StaticMDCBinder();