Skip to content

Commit

Permalink
feat: all rebass components considered as global variables
Browse files Browse the repository at this point in the history
  • Loading branch information
JounQin committed Aug 11, 2019
1 parent e59cbdc commit a36a69b
Show file tree
Hide file tree
Showing 7 changed files with 415 additions and 49 deletions.
34 changes: 21 additions & 13 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,21 +64,29 @@ npm i -D @rxts/eslint-plugin-mdx

2. If you're using `eslint@^5.0.0`, you need to enable this parser/plugin manually, because `eslint@5` does not support `extends` for `overrides` property in its configuration:

```json
{
"extends": ["plugin:@rxts/mdx/recommended"],
"overrides": [
```js
const rebass = require('rebass')

module.exports = {
extends: ['plugin:@rxts/mdx/recommended'],
overrides: [
{
"files": ["*.mdx"],
"globals": {
"React": false
files: ['*.mdx'],
globals: Object.keys(rebass).reduce(
(globals, Component) =>
Object.assign(globals, {
[Component]: false,
}),
{
React: false,
},
),
rules: {
'lines-between-class-members': 0,
'react/react-in-jsx-scope': 0,
},
"rules": {
"lines-between-class-members": 0,
"react/react-in-jsx-scope": 0
}
}
]
},
],
}
```

Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
"@types/jest": "^24.0.17",
"@types/node": "^12.7.1",
"@types/react": "^16.9.1",
"@types/rebass": "^3.0.4",
"@types/unist": "^2.0.3",
"babel-eslint": "^10.0.2",
"commitlint": "^8.1.0",
Expand Down
34 changes: 21 additions & 13 deletions packages/eslint-mdx/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,21 +64,29 @@ npm i -D @rxts/eslint-plugin-mdx

2. If you're using `eslint@^5.0.0`, you need to enable this parser/plugin manually, because `eslint@5` does not support `extends` for `overrides` property in its configuration:

```json
{
"extends": ["plugin:@rxts/mdx/recommended"],
"overrides": [
```js
const rebass = require('rebass')

module.exports = {
extends: ['plugin:@rxts/mdx/recommended'],
overrides: [
{
"files": ["*.mdx"],
"globals": {
"React": false
files: ['*.mdx'],
globals: Object.keys(rebass).reduce(
(globals, Component) =>
Object.assign(globals, {
[Component]: false,
}),
{
React: false,
},
),
rules: {
'lines-between-class-members': 0,
'react/react-in-jsx-scope': 0,
},
"rules": {
"lines-between-class-members": 0,
"react/react-in-jsx-scope": 0
}
}
]
},
],
}
```

Expand Down
34 changes: 21 additions & 13 deletions packages/eslint-plugin-mdx/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,21 +64,29 @@ npm i -D @rxts/eslint-plugin-mdx

2. If you're using `eslint@^5.0.0`, you need to enable this parser/plugin manually, because `eslint@5` does not support `extends` for `overrides` property in its configuration:

```json
{
"extends": ["plugin:@rxts/mdx/recommended"],
"overrides": [
```js
const rebass = require('rebass')

module.exports = {
extends: ['plugin:@rxts/mdx/recommended'],
overrides: [
{
"files": ["*.mdx"],
"globals": {
"React": false
files: ['*.mdx'],
globals: Object.keys(rebass).reduce(
(globals, Component) =>
Object.assign(globals, {
[Component]: false,
}),
{
React: false,
},
),
rules: {
'lines-between-class-members': 0,
'react/react-in-jsx-scope': 0,
},
"rules": {
"lines-between-class-members": 0,
"react/react-in-jsx-scope": 0
}
}
]
},
],
}
```

Expand Down
3 changes: 2 additions & 1 deletion packages/eslint-plugin-mdx/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
"eslint-plugin-react": ">=7.0.0"
},
"dependencies": {
"eslint-mdx": "^0.10.0"
"eslint-mdx": "^0.10.0",
"rebass": "^4.0.2"
}
}
14 changes: 11 additions & 3 deletions packages/eslint-plugin-mdx/src/configs/overrides.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,18 @@
import { base } from './base'

import * as rebass from 'rebass'

export const overrides = {
...base,
globals: {
React: false,
},
globals: Object.keys(rebass).reduce<Record<string, false>>(
(globals, Component) =>
Object.assign(globals, {
[Component]: false,
}),
{
React: false,
},
),
rules: {
'lines-between-class-members': 0, // See /~https://github.com/mdx-js/mdx/issues/195
'react/react-in-jsx-scope': 0,
Expand Down
Loading

0 comments on commit a36a69b

Please sign in to comment.