Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add singlethreaded fence intrinsics. #22358

Closed
wants to merge 1 commit into from

Conversation

tari
Copy link
Contributor

@tari tari commented Feb 15, 2015

These new intrinsics are comparable to atomic_signal_fence in C++,
ensuring the compiler will not reorder memory accesses across the
barrier, nor will it emit any machine instructions for it.

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@tari tari force-pushed the singlethread-fences branch from 27bc9ab to 0c8f7a4 Compare February 15, 2015 18:38
These new intrinsics are comparable to `atomic_signal_fence` in C++,
ensuring the compiler will not reorder memory accesses across the
barrier, nor will it emit any machine instructions for it.
@tari tari force-pushed the singlethread-fences branch from 0c8f7a4 to d754333 Compare February 15, 2015 18:38
@alexcrichton
Copy link
Member

Currently we are planning to remove the entire intrinsics module from the public-facing API of the standard library, in which case we may not want to add these at this time. I think that when adding these intrinsics they would also want to be exposed in a public-facing soon-to-be-stable location as well, but this sort of addition to the standard library requires an RFC.

In short, I believe that an RFC is needed for these changes. Feel free to open an issue in the RFC repo, and I could also help out with writing an RFC if you need it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants