-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-sync libstd dependencies with backtrace #126292
Conversation
3ec9d8d bumped addr2line to 0.22 for some reason, while backtrace uses 0.21.
rustbot has assigned @Mark-Simulacrum. Use |
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
Ideally, I'd like this fixed on beta too. |
? huh, sorry about making that mistake. |
wait, what? |
that's 0.3.73, you upgraded to 0.3.72. |
Actually, Cargo.lock says 0.3.71. |
@glandium That's a version of backtrace used in color-eyre which is used in the compiler and the test suite, independently of std, it has nothing to do with the dependencies of std. |
I realize this result may be confusing... it certainly annoys me a bit... but I don't intend to block our release cadence of libstd dependency updates on making sure that all the dependencies of the compiler and its tools, which are compiled separately, perfectly agree, unless it is absolutely imperative that they do. This "for some reason" was because backtrace is transcluded as a module into libstd, thus meaning that the Cargo.lock is utterly irrelevant for it per se because it is then compiled as a module and not a separate crate! Lines 670 to 672 in ebcb862
And if you think this is a silly state of affairs, I agree! |
Oh boy, I'm in between a rock and a hard place aren't I. Well, this mess breaks forward ports of rust-lang/cargo#8834 and #78790 ... :( |
...Hmm, that sucks! @glandium I will try to see if this can get settled in rust 1.81.0 / backtrace 0.3.74, can you open an issue describing the problem in more detail? |
well, libstd does get two gimlis for |
I opened nbdd0121/unwinding#30 |
Well, since this isn't the first time this happens (last time was duplicated cfg-if), I just went ahead and finally figured out what was missing to make those patches work with multiple crates with the same name but different versions. |
3ec9d8d bumped addr2line to 0.22 for some reason, while backtrace uses 0.21.