Add back help_on_error
for download-ci-llvm
#97503
Labels
E-easy
Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
E-mentor
Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
I accidentally missed this when porting it to rustbuild: /~https://github.com/rust-lang/rust/pull/95170/files#diff-9e25a089f077eae8c8cefe9586cc07498e64cd950be4c954cb90e4245e5f9fc3L634-L651
It would be nice to add it back.
Mentoring instructions: Add a new
help_on_error
parameter toBuilder::download_component_helper
and pass it down fromdownload_ci_llvm
:rust/src/bootstrap/builder.rs
Line 872 in 00bb4df
rust/src/bootstrap/native.rs
Line 182 in 00bb4df
This code moved around in #96687 so you may want to base your changes off that PR until it lands.
@rustbot label +E-easy +E-mentor +A-rustbuild
The text was updated successfully, but these errors were encountered: