Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back help_on_error for download-ci-llvm #97503

Closed
jyn514 opened this issue May 29, 2022 · 2 comments · Fixed by #97519
Closed

Add back help_on_error for download-ci-llvm #97503

jyn514 opened this issue May 29, 2022 · 2 comments · Fixed by #97519
Assignees
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jyn514
Copy link
Member

jyn514 commented May 29, 2022

I accidentally missed this when porting it to rustbuild: /~https://github.com/rust-lang/rust/pull/95170/files#diff-9e25a089f077eae8c8cefe9586cc07498e64cd950be4c954cb90e4245e5f9fc3L634-L651

It would be nice to add it back.

Mentoring instructions: Add a new help_on_error parameter to Builder::download_component_helper and pass it down from download_ci_llvm:

pub(crate) fn download_component(&self, base: &str, url: &str, dest_path: &Path) {
builder.download_component(base, &format!("{}/{}", url, filename), &tarball);

This code moved around in #96687 so you may want to base your changes off that PR until it lands.

@rustbot label +E-easy +E-mentor +A-rustbuild

@rustbot rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels May 29, 2022
@jyn514
Copy link
Member Author

jyn514 commented May 29, 2022

Please also remove the dead code from bootstrap.py at the same time:

if help_on_error is not None:
err += "\n" + help_on_error

@eightfilms
Copy link
Contributor

@rustbot claim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants