Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle std features with a new option in config.toml #129599

Closed
onur-ozkan opened this issue Aug 26, 2024 · 4 comments
Closed

handle std features with a new option in config.toml #129599

onur-ozkan opened this issue Aug 26, 2024 · 4 comments
Assignees
@shrirambalaji
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@onur-ozkan
Copy link
Member

onur-ozkan commented Aug 26, 2024 •
edited by rustbot
Loading

Currently there are multiple ways to enable std features during bootstrap, which can be confusing to newcomers on this project.

To simplify this, add a new option under the rustc section in the config.toml, and handle it in the following function:

rust/src/bootstrap/src/lib.rs

Line 646 in 697d953

fn std_features(&self, target: TargetSelection) -> String {

@rustbot label +E-easy +E-mentor +E-help-wanted +T-bootstrap
@rustbot rustbot added needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Aug 26, 2024
@onur-ozkan onur-ozkan removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Aug 26, 2024
@shrirambalaji
Copy link
Contributor

@onur-ozkan I'd like to pick this up, haven't contributed to rustc before so might need some mentoring

@onur-ozkan
Copy link
Member Author

@onur-ozkan I'd like to pick this up

You can claim the issue by using rustbot.

haven't contributed to rustc before so might need some mentoring

Feel free to ask me any questions on Zulip, or ping me here under the issue or an open PR.

@shrirambalaji
Copy link
Contributor

@rustbot claim

@shrirambalaji shrirambalaji mentioned this issue Sep 11, 2024
Closed
@ismailarilik ismailarilik mentioned this issue Oct 7, 2024
Merged
@onur-ozkan
Copy link
Member Author

Done by #131315.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shrirambalaji shrirambalaji

Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bootstrap: add rust.std-features config shrirambalaji/rust
3 participants
@shrirambalaji @onur-ozkan @rustbot