Skip to content

Commit

Permalink
fix: skip implied bounds if unconstrained lifetime exists
Browse files Browse the repository at this point in the history
  • Loading branch information
Ezrashaw committed Apr 13, 2023
1 parent a29dada commit ecf2a9b
Show file tree
Hide file tree
Showing 3 changed files with 46 additions and 1 deletion.
11 changes: 10 additions & 1 deletion compiler/rustc_trait_selection/src/traits/outlives_bounds.rs
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,16 @@ impl<'a, 'tcx: 'a> InferCtxtExt<'a, 'tcx> for InferCtxt<'tcx> {
) -> Vec<OutlivesBound<'tcx>> {
let ty = self.resolve_vars_if_possible(ty);
let ty = OpportunisticRegionResolver::new(self).fold_ty(ty);
assert!(!ty.needs_infer());

// We must avoid processing constrained lifetime variables in implied
// bounds. See #110161 for context.
if ty.needs_infer() {
self.tcx.sess.delay_span_bug(
self.tcx.source_span_untracked(body_id),
"skipped implied_outlives_bounds due to unconstrained lifetimes",
);
return vec![];
}

let span = self.tcx.def_span(body_id);
let result = param_env
Expand Down
24 changes: 24 additions & 0 deletions tests/ui/implied-bounds/issue-110161.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
// ICE regression relating to unconstrained lifetimes in implied
// bounds. See #110161.

// compile-flags: --crate-type=lib

trait Trait {
type Ty;
}

// erroneous `Ty` impl
impl Trait for () {
//~^ ERROR not all trait items implemented, missing: `Ty` [E0046]
}

// `'lt` is not constrained by the erroneous `Ty`
impl<'lt, T> Trait for Box<T>
where
T: Trait<Ty = &'lt ()>,
{
type Ty = &'lt ();
}

// unconstrained lifetime appears in implied bounds
fn test(_: <Box<()> as Trait>::Ty) {}
12 changes: 12 additions & 0 deletions tests/ui/implied-bounds/issue-110161.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
error[E0046]: not all trait items implemented, missing: `Ty`
--> $DIR/issue-110161.rs:11:1
|
LL | type Ty;
| ------- `Ty` from trait
...
LL | impl Trait for () {
| ^^^^^^^^^^^^^^^^^ missing `Ty` in implementation

error: aborting due to previous error

For more information about this error, try `rustc --explain E0046`.

0 comments on commit ecf2a9b

Please sign in to comment.