Get rid of named_pos in format_args impl.

rust-lang · Aug 8, 2022 · a639fdb · a639fdb
1 parent 2808e07
commit a639fdb
Showing 1 changed file with 1 addition and 5 deletions.
diff --git a/compiler/rustc_builtin_macros/src/format.rs b/compiler/rustc_builtin_macros/src/format.rs
@@ -1316,8 +1316,6 @@ pub fn expand_preparsed_format_args(
         .map(|span| fmt_span.from_inner(InnerSpan::new(span.start, span.end)))
         .collect();
 
-    let named_pos: FxHashSet<usize> = names.values().cloned().collect();
-
     let mut cx = Context {
         ecx,
         args,
@@ -1388,11 +1386,9 @@ pub fn expand_preparsed_format_args(
         .enumerate()
         .filter(|(i, ty)| ty.is_empty() && !cx.count_positions.contains_key(&i))
         .map(|(i, _)| {
-            let msg = if named_pos.contains(&i) {
-                // named argument
+            let msg = if cx.args[i].name.is_some() {
                 "named argument never used"
             } else {
-                // positional argument
                 "argument never used"
             };
             (cx.args[i].expr.span, msg)