Register redundant_field_names and non_expressive_names as early passes #5589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking over! Sadly the problem wasn't only the merge conflict, but some FPs/FNs that got introduced by these changes. Once Clippy builds again, this should show up on CI on this PR. |
|
Everything should be fixed in the original PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves merge conflict that keeps PR #5518 from being merged.
Fixes #5356
Fixes #5521
Closes #5518
Original author of this PR: @flip1995
Edit: I am sorry, but I wasn't aware that there are underlying issues building clippy at the moment. I was assuming
masterwould compile.