Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider confirming that the TypeIds used in a crate are unique #664

Open
steveklabnik opened this issue Jan 21, 2015 · 0 comments
Open

Consider confirming that the TypeIds used in a crate are unique #664

steveklabnik opened this issue Jan 21, 2015 · 0 comments
Labels
T-compiler Relevant to the compiler team, which will review and decide on the RFC.

Comments

@steveklabnik
Copy link
Member

Issue by huonw
Thursday Sep 11, 2014 at 22:03 GMT

For earlier discussion, see rust-lang/rust#17179

This issue was labelled with: A-an-interesting-project in the Rust repository

If two TypeIds of different types collide, we can get unsoundness, since Any relies on TypeId being unique for safe downcasts. We could have the compiler double check that any TypeIds it computes haven't occured before from another type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-compiler Relevant to the compiler team, which will review and decide on the RFC.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@steveklabnik @petrochenkov