asyncread + asyncwrite trait impl on GzEncoder and GzDecoder #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops sorry for the delay here! IIRC these weren't added historically because the actual implementations weren't ready for async usage, something about them required something to be synchronous. I sort of forget though which aspect that was, and it may not be true any more... In any case some tests would be good to add (especially some that limited reads to succeed with maximally one byte at a time), and then this seems fine to add! |
|
You are correct! I experimented with it and I'm getting different results in an asynchronous flow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP - need to add tests. help appreciated.