-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for embedded-hal to 1.0.0-rc.2 #159
Conversation
embedded-hal 1.0.0-rc.2 introduces backwards incompatible changes. This change pins the crate to 1.0.0-rc.1.
I don't think we should accept this PR, instead we should upgrade riscv to the newest release candidate. Would you mind PRing that instead? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!! I left you a couple of comments, please address them before accepting the PR
Hmm... maybe we need to bump riscv-rt to 1.60? |
You will probably also need to update the CI to make it pass: riscv/.github/workflows/riscv-rt.yaml Line 14 in f8c3923
|
1.60.0 appears to be problematic as well. |
Seems that the issue comes with I'll try to develop a quick solution to stop using this dependency and allow us to leave the MSRV to 1.60 |
@purplethunder check #160 and use my commit to get rid of the |
Closing as #160 now solves this |
embedded-hal 1.0.0-rc.2 introduced backwards incompatible changes that break riscv builds. This change pins the crate to 1.0.0-rc.1.