Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for embedded-hal to 1.0.0-rc.2 #159

Closed
wants to merge 10 commits into from

Conversation

purplethunder
Copy link
Contributor

embedded-hal 1.0.0-rc.2 introduced backwards incompatible changes that break riscv builds. This change pins the crate to 1.0.0-rc.1.

error[E0432]: unresolved import `embedded_hal::delay::DelayUs`
 --> riscv/src/delay.rs:3:5
  |
3 | use embedded_hal::delay::DelayUs;
  |     ^^^^^^^^^^^^^^^^^^^^^-------
  |     |                    |
  |     |                    help: a similar name exists in the module: `DelayNs`
  |     no `DelayUs` in `delay`

For more information about this error, try `rustc --explain E0432`.

embedded-hal 1.0.0-rc.2 introduces backwards incompatible changes.  This change pins the crate to 1.0.0-rc.1.
@purplethunder purplethunder requested a review from a team as a code owner November 29, 2023 23:28
@MabezDev
Copy link
Member

I don't think we should accept this PR, instead we should upgrade riscv to the newest release candidate. Would you mind PRing that instead?

@purplethunder purplethunder changed the title Pin embedded-hal to 1.0.0-rc.1 Update for embedded-hal to 1.0.0-rc.2 Nov 30, 2023
Copy link
Contributor

@romancardenas romancardenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!! I left you a couple of comments, please address them before accepting the PR

riscv/src/delay.rs Outdated Show resolved Hide resolved
riscv/src/delay.rs Outdated Show resolved Hide resolved
@romancardenas
Copy link
Contributor

Hmm... maybe we need to bump riscv-rt to 1.60?

@romancardenas
Copy link
Contributor

You will probably also need to update the CI to make it pass:

toolchain: [ stable, nightly, 1.59.0 ]

@purplethunder
Copy link
Contributor Author

1.60.0 appears to be problematic as well.

@romancardenas
Copy link
Contributor

Seems that the issue comes with riscv-target, used for building the riscv-rt crate and check the different RISC-V extensions...

I'll try to develop a quick solution to stop using this dependency and allow us to leave the MSRV to 1.60

@romancardenas
Copy link
Contributor

@purplethunder check #160 and use my commit to get rid of the riscv-target build dependency. I think with that you should be able to pass the CI

@romancardenas
Copy link
Contributor

Closing as #160 now solves this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants