Fix bug that would overwrite the content of the response body when using multiple presenters #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing multiple presenters (utilizing the 'root' in the presenter rather than passing the root in the present method). Add conditional logic to inside_route#present that checks if we are using an entity, if so we merge appropriately so nothing is overwritten. Add test to inside_route_spec.rb.
| @@ -188,6 +188,13 @@ def present(*args) | |||
|
|
|||
| representation = { root => representation } if root | |||
| representation = (@body || {}).merge(key => representation) if key | |||
|
|
|||
| # If root and key are nil but we have entity, merge using the representation from entity. | |||
There was a problem hiding this comment.
This is mutually exclusive with above, change it to be something like
if key
# ...
elsif ...
# ...
end…rify issue description in CHANGELOG.md
|
Any additional thoughts on this one? |
|
Sorry, I didn't see it was updated. Merged via 9cf4c7e. Thank you. |
|
I ran into #1023 which was caused by this change. I am going to change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using multiple presenters that make use of Grape Entity, if the user does not specify the root when calling the present method, the contents added to the body by the first presenter would be overwritten by the second presenter.
This issue becomes apparent when the user does not pass a root to the present method but instead opts to use the 'root' inside the Grape Entity being provided to present method.