Clone non-frozen default params with each use (#1438) #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlfaber
force-pushed
the
bug_#1438
branch
2 times, most recently
from
d72edad to
706713c
Compare
|
Rebased. All tests now passing, so this is ready for review. @dblock |
| @@ -12,6 +12,7 @@ | |||
|
|
|||
| #### Fixes | |||
|
|
|||
| * [#1438](/~https://github.com/ruby-grape/grape/pull/1439): Fix for default param modification bug - [@jlfaber](/~https://github.com/jlfaber). | |||
There was a problem hiding this comment.
Lets write something more useful, maybe "Default values in params are now cloned on assignment"?
|
@dblock, I've updated the PR:
This should be ready to go if you concur with the changes. |
| @@ -6,8 +6,30 @@ def initialize(attrs, options, required, scope) | |||
| super | |||
| end | |||
|
|
|||
| # return true if we know we cannot dup this object | |||
| private def cannot_dup(obj) | |||
There was a problem hiding this comment.
Should be ....?, but I would write this as the other way around, so maybe duplicatable?, which is how ActiveRecord calls these things I believe.
|
This is good. I have nitpicks on naming, otherwise it's ready to go. |
|
Renamed and reformatted as requested by @dblock . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.