Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#498] Dry up OPTIONS regression #573

Closed
etehtsea opened this issue Feb 7, 2014 · 5 comments
Closed

[#498] Dry up OPTIONS regression #573

etehtsea opened this issue Feb 7, 2014 · 5 comments

Comments

@etehtsea
Copy link
Contributor

etehtsea commented Feb 7, 2014

This pull request broke OPTIONS for endpoints mounted inside root app with version.

Link to demo app

@dblock
Copy link
Member

dblock commented Feb 7, 2014

Could you please write a test for this in Grape proper? Appreciate it.

@dblock dblock added the bug? label Feb 7, 2014
@dblock
Copy link
Member

dblock commented Feb 7, 2014

cc: @karlfreeman

@etehtsea
Copy link
Contributor Author

etehtsea commented Feb 7, 2014

@dblock I added failing spec, but I need feedback where the proper place for it and how to name it.

@dblock
Copy link
Member

dblock commented Feb 7, 2014

I think its location is fine. Now can you fix it? :)

@karlfreeman
Copy link
Contributor

Thought I'd chime in on this.

Giving this a quick look at, I'm able to reproduce the error with this test karlfreeman@109d4e3 (eg the first test passes, whereas the second doesn't). It appears that using path versioning with a mounted api fails. I'm not going to be able to commit the time to fix this but figured I'd see if it was something simple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants