Merge pull request #294 from G-Rath/error-on-tests-failure

Raise an exception if tests or changelog generation fails

.github/workflows/test.yml

@@ -50,6 +50,8 @@ jobs:
           bundler-cache: true
       - name: test
         run: bundle exec rake test
+        env:
+          ERROR_ON_TEST_FAILURE: "false"
       - name: internal_investigation
         run: bundle exec rake internal_investigation
 
@@ -84,3 +86,5 @@ jobs:
           bundler-cache: true
       - name: test
         run: bundle exec rake test
+        env:
+          ERROR_ON_TEST_FAILURE: "false"

Rakefile

@@ -21,7 +21,9 @@ require_relative 'lib/rubocop/cop/generator'
 
 desc 'Run tests'
 task :test do
-  system("bundle exec minitest-queue #{Dir.glob('test/**/*_test.rb').shelljoin}")
+  error_on_failure = ENV.fetch('ERROR_ON_TEST_FAILURE', 'true') != 'false'
+
+  system("bundle exec minitest-queue #{Dir.glob('test/**/*_test.rb').shelljoin}", exception: error_on_failure)
 end
 
 desc 'Run RuboCop over itself'

tasks/changelog.rake

@@ -9,7 +9,7 @@ namespace :changelog do
       ref_type = :pull if args[:id]
       path = Changelog::Entry.new(type: type, ref_id: args[:id], ref_type: ref_type).write
       cmd = "git add #{path}"
-      system cmd
+      system cmd, exception: true
       puts "Entry '#{path}' created and added to git index"
     end
   end
@@ -21,7 +21,7 @@ namespace :changelog do
     Changelog.new.merge!.and_delete!
     cmd = "git commit -a -m 'Update Changelog'"
     puts cmd
-    system cmd
+    system cmd, exception: true
   end
 
   task :check_clean do