Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert to default update as in ROS1 #1214

Open
wants to merge 2 commits into
base: ros2
Choose a base branch
from

Conversation

iluetkeb
Copy link

This reverts the clock update frequency back to the ROS 1 value of 1kHz, in response to #1211.

@chapulina chapulina added the ros2 label Feb 17, 2021
@kamille6
Copy link

kamille6 commented Feb 19, 2021

Has it been determined why the check is failing? Is there some way I could help move this along? I am in need of a faster /clock and would like to eventually not have to build gazebo_ros_pkgs from source for my project just to get a faster /clock. Thank you!

@robin-read
Copy link

When trying to open the link for the failed test I get a 404 error which is a bit concerning.

This is a small and easy change/win that will certainly make the migration to ROS2 much cleaner for the community at large. To echo the comment from @kamille6, having to clone this repo to get a one line change is a bit cumbersome.

To the maintainers, please could you have a look at this PR? It would be much appreciated.

Thanks!

@bednarhonza
Copy link

Hello guys, any update on this? It would be very welcomed!

Thanks!

@iluetkeb
Copy link
Author

iluetkeb commented Aug 6, 2021

We did some more testing on the meantime, and anything beyond 250Hz causes simulation slowdown, so I would probably modify this a bit by now.
Also, we found that you actually can pass this as an argument, by giving it on the command-line (in contrast to adding it to the models, which doesn't work). Just stick it into a YAML file and give that as a --ros-args argument when starting gzserver.

@bednarhonza
Copy link

I have tried to set the rate at 250 Hz, but my simulation does not go above 160 Hz. My CPU should be able to handle this, I have the real-time factor 1.0 as well.

I'm trying to launch it through default gazebo.launch.py. Could you help me with setting the parameter via the launch file?

@iluetkeb
Copy link
Author

iluetkeb commented Aug 6, 2021

You can set the launch variable extra_gazebo_args to --ros-args --params-file <your-yaml>

@bednarhonza
Copy link

Thanks, that works. I have set the rate to 100 Hz, but the /clock runs at 83 Hz. Is there any other reason for that?

@jacobperron
Copy link
Collaborator

Change the default frequency sounds reasonable to me; it would be good to know the reason for the discrepancy between the desired and actual publish rate.. though I suppose we can ticket that separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants