Skip to content

Commit

Permalink
feat: enforce conventional commits
Browse files Browse the repository at this point in the history
fix: disable ruff in ci
  • Loading branch information
Gaisberg authored and Gaisberg committed Jul 23, 2024
1 parent 5bf802d commit 5ffddc1
Show file tree
Hide file tree
Showing 3 changed files with 34 additions and 16 deletions.
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
name: Run Battery of Checks for Backend
name: Linting and Testing

on: [push, pull_request]
on:
pull_request:
branches: [ main ]

jobs:
battery:
Expand Down Expand Up @@ -32,19 +34,19 @@ jobs:
pip install poetry
poetry install --no-root --with dev

# - name: Ruff & Isort Check
# run: |
# poetry run ruff check ./src
# poetry run isort --check-only ./src
- name: Ruff & Isort Check
run: |
poetry run ruff check ./src
poetry run isort --check-only ./src

# - name: Type check
# run: poetry run pyright
- name: Type check
run: poetry run pyright

# - name: Run Tests & Coverage
# run: poetry run pytest --cov=./src --cov-report=xml
- name: Run Tests & Coverage
run: poetry run pytest --cov=./src --cov-report=xml

# - name: Upload Coverage Report to Codecov
# uses: codecov/codecov-action@v4.1.1
# with:
# token: ${{ secrets.CODECOV_TOKEN }}
# file: ./coverage.xml
- name: Upload Coverage Report to Codecov
uses: codecov/codecov-action@v4.1.1
with:
token: ${{ secrets.CODECOV_TOKEN }}
file: ./coverage.xml
16 changes: 16 additions & 0 deletions .github/workflows/conventional-commits.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
name: Conventional Commits

on:
pull_request:
branches: [ main ]

jobs:
build:
name: Conventional Commits
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: webiny/action-conventional-commits@v1.3.0
#with:
#GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Optional, for private repositories.
#allowed-commit-types: "feat,fix," # Optional, set if you want a subset of commit types to be allowed.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ We welcome contributions from the community! To ensure a smooth collaboration, p
### Submitting Changes
1. **Open an Issue**: For major changes, start by opening an issue to discuss your proposed modifications. This helps us understand your intentions and provide feedback early in the process.
2. **Pull Requests**: Once your changes are ready, submit a pull request. Ensure your code adheres to our coding standards and passes all tests.
2. **Pull Requests**: Once your changes are ready, submit a pull request. Ensure your code adheres to our coding standards and passes all tests. Commits should follow [conventional-commits](https://www.conventionalcommits.org/) specification.
### Code Formatting
Expand Down

0 comments on commit 5ffddc1

Please sign in to comment.