Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updateVariationImages 404 error - "Resource Not Found" #5

Closed
developerarun opened this issue Sep 2, 2021 · 2 comments
Closed

updateVariationImages 404 error - "Resource Not Found" #5

developerarun opened this issue Sep 2, 2021 · 2 comments

Comments

@developerarun
Copy link

developerarun commented Sep 2, 2021

I Found an issue while updating variation images using updateVariationImages
After printing the actual response I got a "Resource Not Found" Error and it is due to request method

  /**
   * Updates variation images for the listing. You MUST pass data for ALL variation images, including the ones you are not updating, as this method will override all existing variation images.
   *
   * @link https://developers.etsy.com/documentation/reference#operation/updateVariationImages
   * @param array $data
   * @return Etsy\Collection[Etsy\Resources\ListingVariationImage]
   */
  public function updateVariationImages(array $data) {
    return $this->request(
      "PUT",
      "/application/shops/{$this->shop_id}/listings/{$this->listing_id}/variation-images",
      "ListingVariationImage",
      $data
    );
  }
  
  As Per doc it should be of POST type instead of PUT 
  
  https://developer.etsy.com/documentation/reference/#operation/updateVariationImages
  
    public function updateVariationImages(array $data) {
    return $this->request(
      "POST",
      "/application/shops/{$this->shop_id}/listings/{$this->listing_id}/variation-images",
      "ListingVariationImage",
      $data
    );
  }
@rhysnhall
Copy link
Owner

Thanks for this. I will have a look and update.
Have you tested it with the POST to confirm that works?

@developerarun
Copy link
Author

Thanks for this. I will have a look and update.
Have you tested it with the POST to confirm that works?

Yes i tested with POST its working

@ELY3M ELY3M mentioned this issue Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants