Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename --delimiter parameter into --bulk-separator #84

Closed
rdagumampan opened this issue May 3, 2020 · 1 comment
Closed

Rename --delimiter parameter into --bulk-separator #84

rdagumampan opened this issue May 3, 2020 · 1 comment
Assignees
@rdagumampan
Labels
first-timer-friendly Light and easy start implementing
Milestone
v1.0-06.27.2020

Comments

@rdagumampan
Copy link
Owner

For consistency of all bulk import related parameters, it would be better to rename the existing parameter --delimiter into --bulk-separator. The parameter is currently placed in BaseRunPlatformOption.cs.

Expected list of changes:

  • Modify BaseRunPlatformOption.cs to rename the CLI parameter
  • Fix all broken unit tests and integration tests
  • Update the documentation in yuniql.io
@rdagumampan rdagumampan added help wanted You're welcome to work on it right away first-timer-friendly Light and easy start labels May 3, 2020
@rdagumampan rdagumampan added this to the v1.0 milestone May 16, 2020
@rdagumampan rdagumampan self-assigned this May 18, 2020
@rdagumampan rdagumampan added implementing and removed implementing help wanted You're welcome to work on it right away labels May 21, 2020
@rdagumampan
Copy link
Owner Author

Done. Will be part of release v1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rdagumampan rdagumampan

Labels
first-timer-friendly Light and easy start implementing
Projects
None yet
Milestone
v1.0-06.27.2020
Development

No branches or pull requests
1 participant
@rdagumampan