Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rails/importmap-rails
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.0.1
Choose a base ref
...
head repository: rails/importmap-rails
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.0.2
Choose a head ref
  • 20 commits
  • 28 files changed
  • 11 contributors

Commits on Jan 23, 2024

  1. Add package information in vendored package file (#227)

    Now that the packages are downloaded by default, apart from the output of the `pin` command we lose the track of the version and from where the package was downloaded. To track the version the solution was use a comment in bin/importmap next to the package version but nothing for the package origin so the proposal is add a comment in the first line of the downloaded package displaying the package name, version and from where it was downloaded.
    faqndo97 authored Jan 23, 2024
    Configuration menu
    Copy the full SHA
    699a9bb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ddf9be4 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2024

  1. Configuration menu
    Copy the full SHA
    eae70a3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6e4b036 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. Add breaking test

    See #245 for context.
    
    The TL;DR is the response sometimes returns a String instead of Hash object. This should be handled properly.
    
    The way to handle this is up for discussion. To start addressing the issue the String response will just be surfaced as `latest_version`.
    vietqhoang committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    a0fb029 View commit details
    Browse the repository at this point in the history
  2. Surface String response

    vietqhoang committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    41b84fb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    40df253 View commit details
    Browse the repository at this point in the history
  4. Reduce the number of assertions

    We only care to assert on the `latest_version` since this is what we care about. Can revert the change if it is desired to assert the rest.
    vietqhoang committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    38fb116 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2024

  1. Configuration menu
    Copy the full SHA
    f2779ee View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. Merge pull request #238 from calebowens/fix-regex-for-super-indexes

    Updated module_name regexp to not match incorrect indexes
    rafaelfranca authored Apr 19, 2024
    Configuration menu
    Copy the full SHA
    2ecde30 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #239 from calebowens/fix-rakefile-loading-twice

    Invoke app:template via Rake::Task[].invoke to avoid reloading rakefile
    rafaelfranca authored Apr 19, 2024
    Configuration menu
    Copy the full SHA
    61054a1 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #246 from vietqhoang/handle-string-response-for-fi…

    …nd-latest-version
    
    Handle String response for "find latest version"
    rafaelfranca authored Apr 19, 2024
    Configuration menu
    Copy the full SHA
    1d93e41 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5144677 View commit details
    Browse the repository at this point in the history
  5. Fix test with Rails main

    `fixture_path` was removed in Rails 7.2.
    rafaelfranca committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    0a63301 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2024

  1. Fix 302/304 mixup (#260)

    schmijos authored Sep 15, 2024
    Configuration menu
    Copy the full SHA
    11e59ae View commit details
    Browse the repository at this point in the history
  2. Allows preload to be determined by provided entry_point (#253)

    * Allows preload to be determined by provided entry_point
    
    * entry point defaults and fix
    
    * Tests for various preload values
    
    * Update README.md
    aseroff authored Sep 15, 2024
    Configuration menu
    Copy the full SHA
    e54fd54 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8a7d61c View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Configuration menu
    Copy the full SHA
    cc7142e View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2024

  1. Configuration menu
    Copy the full SHA
    b360120 View commit details
    Browse the repository at this point in the history
  2. Bump version for 2.0.2

    dhh committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    fb55367 View commit details
    Browse the repository at this point in the history
Loading