Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle imported type urls #82

Closed
ghost opened this issue Feb 10, 2020 · 0 comments
Closed

Properly handle imported type urls #82

ghost opened this issue Feb 10, 2020 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@ghost
Copy link

ghost commented Feb 10, 2020

After thinking about https://cwl.discourse.group/t/proper-syntax-for-type-paths/75

If we have a type definition

- $import: ../tools/Trimmomatic/trimmomatic-end_mode.yaml

should the type usage be

    type: ../tools/Trimmomatic/trimmomatic-end_mode.yaml#end_mode

and If the type definition is

- $import: ./trimmomatic-end_mode.yaml

both

    type: trimmomatic-end_mode.yaml#end_mode

and

    type: ./trimmomatic-end_mode.yaml#end_mode

are valid.

i.e the string following type should be a valid URL that resolves to one of the URL's indicated in an $import statement earlier on in the types field.

@ghost ghost added the bug Something isn't working label Feb 10, 2020
@ghost ghost added this to the 2020.02.29 milestone Feb 10, 2020
@ghost ghost self-assigned this Feb 10, 2020
@ghost ghost closed this as completed in 0b9f224 Feb 12, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

0 participants