Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error reporting of satpy.utils.get_satpos #1496

Closed
sfinkens opened this issue Jan 4, 2021 · 1 comment
Closed

Improve error reporting of satpy.utils.get_satpos #1496

sfinkens opened this issue Jan 4, 2021 · 1 comment
Assignees
@sfinkens
Labels
enhancement code enhancements, features, improvements

Comments

@sfinkens
Copy link
Member

sfinkens commented Jan 4, 2021

Feature Request

Is your feature request related to a problem? Please describe.

Some computations in satpy require the actual satellite position (lat, lon, alt), which can be provided via attributes orbital_parameters or satellite_longitude/latitude/altitude (deprecated). The helper method satpy.utils.get_satpos tries to extract the best match from the available dataset attributes. If none of the above attributes are present, the method fails with a KeyError('satellte_longitude'), see #1494 .

Describe the solution you'd like
The method to provide a more informative error message. Suggestion:

KeyError("Unable to determine actual satellite position. Either the reader doesn't provide that information or geolocation datasets are not available").

Describe any changes to existing user workflow
None

Additional context
None
@sfinkens sfinkens added the enhancement code enhancements, features, improvements label Jan 4, 2021
@sfinkens sfinkens self-assigned this Jan 4, 2021
@sfinkens sfinkens mentioned this issue Dec 6, 2021
Closed
2 tasks
@sfinkens
Copy link
Member Author

sfinkens commented Dec 7, 2023

Closed by #2030

@sfinkens sfinkens closed this as completed Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfinkens sfinkens

Labels
enhancement code enhancements, features, improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve error reporting of get_satpos sfinkens/satpy
1 participant
@sfinkens