Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve memory profiler to not to profile every iteration #422

Closed
tianyu-l opened this issue Jun 24, 2024 · 1 comment
Closed

improve memory profiler to not to profile every iteration #422

tianyu-l opened this issue Jun 24, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@tianyu-l
Copy link
Contributor

Currently if we enable memory profiling, every iteration will be profiled with trace dumped, regardless of profile frequency. This overhead can be avoided if we only profile and dump one iteration per profile_freq steps.

referring to #395 (review)
@tianyu-l tianyu-l added the enhancement New feature or request label Jun 24, 2024
@tianyu-l tianyu-l mentioned this issue Jun 26, 2024
Merged
@awgu
Copy link
Contributor

awgu commented Jul 25, 2024

#430

@awgu awgu closed this as completed Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@awgu @tianyu-l