bpo-41111: Move the Py_LIMITED_API macro of xxlimited module from setup.py to xxlimited.c. #25115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shihai1991
changed the title
vstinner
reviewed
Apr 2, 2021
| self.add(Extension('xxlimited_35', ['xxlimited_35.c'], | ||
| define_macros=[('Py_LIMITED_API', '0x03050000')])) | ||
| define_macros=[('WITH_Py_LIMITED_API', 1)])) | ||
| else: | ||
| # Debug mode: Build xxlimited with the full API | ||
| # (which is compatible with the limited one) |
There was a problem hiding this comment.
Hum, I'm disappointed that CPython doesn't even support its own stable ABI in debug mode. So I created https://bugs.python.org/issue43688 to also support the limited C API in debug mode.
Modules/xxlimited.c
Outdated
| @@ -55,6 +55,10 @@ | |||
| pass | |||
| */ | |||
|
|
|||
| /* xxlimited with the limited API. */ | |||
| #ifdef WITH_Py_LIMITED_API | |||
| # define Py_LIMITED_API 0x03100000 | |||
There was a problem hiding this comment.
0x03100000 is wrong: it must be 0x030a0000 (the bug exists in the current code). I fixed the issue in my PR #25131.
|
Oops. I forgot to publish my review. In the meanwhile, I fixed both issues in https://bugs.python.org/issue43688. I created a new PR: PR #25151. |
|
I merged PR #25151 instead, I marked you as a co-author of my change ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue41111