-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Junction Deviation #2115
Comments
Piggybacking off of this, could we have options for Jerk, Junction, and None? |
+1 |
Maybe do the default thing of having the value 0 as "use default from firmware" for jerk and add another line for junction deviation which can also be disabled with 0 |
+1 |
How to support old marlin and newer marlin? outputting both? |
I know "new marlin" ignores the old commands, not sure going the other way. I too have since moved to Klipper and would like a None option. Or do it how SuperSlicer does it and add a Klipper gcode selector in printer settings |
Unfortunately, even with "new Marlin" there are various possible scenarios, since you can disable Junction Deviation and go back to classic jerk when configuring the firmware. These are the possible options (as of this writing):
I believe Marlin will just ignore any options that are not relevant to the configuration. |
It seems quite easy to support correct time estimation for JD (Junction Deviation). Slicer code uses acceleration and jerk values for calculations, but if I'm correct JD is produced from acceleration and jerk, thus jerk could be calculated from JD and acceleration. According to https://blog.kyneticcnc.com/2018/10/computing-junction-deviation-for-marlin.html so in Is it correct? |
Newer marlin version removed the Jerk support in favor of Junction deviation, thus the
M205 X Y Z
can be replaced withM205 J
A new value in the machine limits should be added, for setting Junction Deviation. If that is set, the jerk value should be removed from the gcode (they are ignored by the firmware)
The text was updated successfully, but these errors were encountered: