Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LDS entries should be bit for bit identical #1096

Closed
davecheney opened this issue May 16, 2019 · 0 comments · Fixed by #1126
Closed

LDS entries should be bit for bit identical #1096

davecheney opened this issue May 16, 2019 · 0 comments · Fixed by #1126
Assignees
@youngnick
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone
0.13.0

Comments

@davecheney
Copy link
Contributor

#499 showed that frequent updates to LDS will cause many draining copies of the older listeners to stay around in memory on the Envoy side. #499 (comment) has more details.

This issue captures the desire to ensure that LDS entries, specifically ingress_https which contains multiple FilterChain entries are sorted so that when a logically identical update is forwarded to Envoy, it can be skipped because its hash is identical to a previous update.

See also #876 which switched all the Filter configurations to be TypedConfig's making them bit for bit identical.
@davecheney davecheney added kind/feature Categorizes issue or PR as related to a new feature. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels May 16, 2019
@davecheney davecheney added this to the 0.13.0 milestone May 16, 2019
@davecheney davecheney mentioned this issue May 16, 2019
Closed
@youngnick youngnick self-assigned this May 23, 2019
@youngnick youngnick mentioned this issue May 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@youngnick youngnick

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
0.13.0
Development

Successfully merging a pull request may close this issue.

Add stable sorting to https listener creation. youngnick/contour
2 participants
@davecheney @youngnick