Skip to content

Commit

Permalink
Test on rails 8.0.0.rc2 (#3424)
Browse files Browse the repository at this point in the history
* Test on rails 8.0.0.rc2

* Don't make any routes in the singular resource

All routes are made by the searchable concern
  • Loading branch information
jcoyne authored Nov 1, 2024
1 parent 32e4f12 commit 74008cf
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ruby.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,10 @@ jobs:
additional_name: [""]
include:
- ruby: "3.3"
rails_version: "8.0.0.beta1"
rails_version: "8.0.0.rc2"
additional_engine_cart_rails_options: --css=bootstrap
- ruby: "3.3"
rails_version: "8.0.0.beta1"
rails_version: "8.0.0.rc2"
additional_engine_cart_rails_options: --css=bootstrap --js=esbuild
additional_name: "/ esbuild"
- ruby: "3.2"
Expand Down
2 changes: 1 addition & 1 deletion lib/generators/blacklight/controller_generator.rb
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def inject_blacklight_routes
route <<-EOF
concern :searchable, Blacklight::Routes::Searchable.new
resource :catalog, only: [:index], as: 'catalog', path: '/catalog', controller: 'catalog' do
resource :catalog, only: [], as: 'catalog', path: '/catalog', controller: 'catalog' do
concerns :searchable
end
EOF
Expand Down
2 changes: 1 addition & 1 deletion lib/generators/blacklight/test_support_generator.rb
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def alternate_controller
copy_file "alternate_controller.rb", "app/controllers/alternate_controller.rb"

routing_code = <<-EOF
resource :alternate, controller: 'alternate', only: [:index] do
resource :alternate, controller: 'alternate', only: [] do
concerns :searchable
end
EOF
Expand Down

0 comments on commit 74008cf

Please sign in to comment.