Skip to content
This repository has been archived by the owner on Oct 6, 2020. It is now read-only.

canProcessNote is falsely marked as a selector #41

Closed
opicacek opened this issue May 9, 2019 · 1 comment · Fixed by #42
Closed

canProcessNote is falsely marked as a selector #41

opicacek opened this issue May 9, 2019 · 1 comment · Fixed by #42
Assignees
@jukben
Labels
bug Something isn't working check-unused-flux-dependencies

Comments

@opicacek
Copy link

opicacek commented May 9, 2019

At the beginning of the file, selector is defined under alias:

import { canProcessNote as canProcessNoteSelector } from 'selectors/InboxSelectors';

In connect dependencies, we correctly list canProcessNoteSelector selector.

Issue:
canProcessNote is falsely marked by tslint as a selector.

/~https://github.com/productboard/pb-frontend/blob/master/src/js/modules/sidebar/components/note/NoteSidebarFooter.react.tsx#L141
@jukben jukben added bug Something isn't working check-unused-flux-dependencies labels May 9, 2019
@jukben
Copy link
Contributor

jukben commented May 9, 2019 •
edited
Loading

🙏

Issue is that property assignment is also taken as flux dependency usage.

@jukben jukben self-assigned this May 9, 2019
@jukben jukben mentioned this issue May 9, 2019
Merged
@jukben jukben closed this as completed in #42 May 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jukben jukben

Labels
bug Something isn't working check-unused-flux-dependencies
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dont treat PropertyAssignments -> Indentifier as Flux Identifier productboardlabs/tslint-pb
2 participants
@opicacek @jukben