Creating stylelint plugin for no deprecated color vars #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3964567 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Conflicts: package-lock.json
Conflicts: yarn.lock
colebemis
reviewed
Aug 31, 2021
plugins/no-deprecated-colors.js
Outdated
| } | ||
|
|
||
| stylelint.utils.report({ | ||
| message: messages.rejected(variableName), |
There was a problem hiding this comment.
If the replacement is an array, can we use that array to make a more specific error message? Something like "text.primary" is deprecated. Use "fg.default" or "fg.muted" instead
colebemis
approved these changes
Aug 31, 2021
Co-authored-by: Cole Bemis <colebemis@github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a plugin that uses /~https://github.com/primer/primitives/blob/main/data/colors_v2/deprecations.json to lint for old css vars and includes auto fix functionality.
@colebemis