Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binding [dt] on Select component has no effect #17540

Closed
WillooWisp opened this issue Jan 30, 2025 · 1 comment · Fixed by #17742
Closed

Binding [dt] on Select component has no effect #17540

WillooWisp opened this issue Jan 30, 2025 · 1 comment · Fixed by #17742
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@WillooWisp
Copy link

WillooWisp commented Jan 30, 2025

<p-select
    appendTo="body"
    [options]="cars"
    [(ngModel)]="selectedCar"
    (onChange)="onCarChange($event.value)"
    optionLabel="label"
    [dt]="noSelectFocus()"
/>

public noSelectFocus = signal({
    root: {
        background: 'green',
        filledBackground: 'green',
        filledHoverBackground: 'green',
        filledFocusBackground: 'green',
        borderColor: 'transparent',
        hoverBorderColor: 'green',
        focusBorderColor: 'green',
        color: 'green',
        shadow: 'none',
        paddingX: 0,
        paddingY: 0
    },
    option: {
        focusBackground: 'green',
        selectedBackground: 'green',
        selectedFocusBackground: 'green',
        color: 'green',
        focusColor: 'green',
        selectedColor: 'green',
        selectedFocusColor: 'green',
    },
});
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 30, 2025
@WillooWisp
Copy link
Author

sm and lg properties also missing from root in SelectDesignTokens.

@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Feb 21, 2025
@mertsincan mertsincan added this to the 19.0.7 milestone Feb 21, 2025
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Feb 21, 2025
@github-project-automation github-project-automation bot moved this from Review to Done in PrimeNG Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants