Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<p-auto-complete> behaves differently than <p-autocomplete> #17535

Closed
1 of 4 tasks
hunhejj opened this issue Jan 30, 2025 · 0 comments · Fixed by #17561
Closed
1 of 4 tasks

<p-auto-complete> behaves differently than <p-autocomplete> #17535

hunhejj opened this issue Jan 30, 2025 · 0 comments · Fixed by #17561
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@hunhejj
Copy link
Contributor

hunhejj commented Jan 30, 2025

Describe the bug

I assumed that <p-autocomplete> and <p-auto-complete> are interchangeable, the output is the same. However that's not true, because there are some stylings explicitly added for p-autocomplete but not for p-auto-complete. An example is for that is the invalid state as showcased in this Stackblitz demo.

Pull Request Link

No response

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

Not sure what is PrimeNG's approach for supporting components with multiple selectors.

Reproducer

https://stackblitz.com/edit/cnhmocdx

Environment

Just a regular environment.

Angular version

19

PrimeNG version

v19

Node version

No response

Browser(s)

No response

Steps to reproduce the behavior

  1. Render a <p-auto-complete> component with an invalid form control
  2. The component has no error border

Expected behavior

I would expect an error border similar to <p-autocomplete>.

@hunhejj hunhejj added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 30, 2025
@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Feb 14, 2025
@mertsincan mertsincan added this to the 19.0.7 milestone Feb 14, 2025
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Feb 14, 2025
@mertsincan mertsincan moved this from Review to Done in PrimeNG Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants