Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datepicker, Multiselect, Message, Toast: Missing aria-labels #17449

Closed
4 tasks
TaneliTuomola opened this issue Jan 21, 2025 · 0 comments · Fixed by #17448
Closed
4 tasks

Datepicker, Multiselect, Message, Toast: Missing aria-labels #17449

TaneliTuomola opened this issue Jan 21, 2025 · 0 comments · Fixed by #17448
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
19.0.6

Comments

@TaneliTuomola
Copy link
Contributor

Describe the bug

  • Datepicker: Missing aria-label on prev and next buttons
  • MultiSelect: Missing aria-label on checkboxes
  • Message: close button missing aria-label
  • Toast: close button missing aria-label

Pull Request Link

#17448

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://primeng.org/

Environment

https://primeng.org/

Angular version

19

PrimeNG version

v19

Node version

No response

Browser(s)

No response

Steps to reproduce the behavior

  1. primeNg.org 2. Open component doc 3. Inspect elements

Expected behavior

Aria-labels fixed
@TaneliTuomola TaneliTuomola added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 21, 2025
@TaneliTuomola TaneliTuomola mentioned this issue Jan 21, 2025
Merged
@mertsincan mertsincan added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 29, 2025
@mertsincan mertsincan added this to the 19.0.6 milestone Jan 29, 2025
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Jan 29, 2025
@github-project-automation github-project-automation bot moved this from Review to Done in PrimeNG Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
PrimeNG
Status: Done
Milestone
19.0.6
Development

Successfully merging a pull request may close this issue.

fix: aria-labels TaneliTuomola/primeng
2 participants
@mertsincan @TaneliTuomola