Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accordion] onOpen and onClose emitter won't trigger any events with the new components for accordion #17447

Closed
1 of 4 tasks
PerdrieauC opened this issue Jan 21, 2025 · 10 comments · Fixed by #17748
Closed
1 of 4 tasks
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@PerdrieauC
Copy link

PerdrieauC commented Jan 21, 2025

Describe the bug

The onOpen and onClose emitter for accordion don't work with the new accordion-header and accordion-content components. The events are triggered when you use the old component p-accordionTab or p-accordion-tab.

Pull Request Link

No response

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://stackblitz.com/edit/github-8n33ys8f?file=src%2Fapp%2Ftest%2Ftest.component.html

Environment

stackblitz

Angular version

19

PrimeNG version

v19

Node version

No response

Browser(s)

Chrome 132

Steps to reproduce the behavior

Link the onClose or onOpen Emitter to p-accordion with p-accordion-panel, header, content.
Try to open or close and accordion panel and nothing is triggered.

Expected behavior

Trigger the events for the onClose and onOpen Emitters with the new accordion components.

@PerdrieauC PerdrieauC added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 21, 2025
@PerdrieauC PerdrieauC changed the title onOpen and onClose emitter won't trigger any events with the new components for accordion [Accordion] onOpen and onClose emitter won't trigger any events with the new components for accordion Jan 31, 2025
@eran10
Copy link

eran10 commented Feb 6, 2025

+1
happened in our case as well, seems like a basic ability that is missing now in the accordion component,
hope this can be fixed soon.

@boydt
Copy link

boydt commented Feb 13, 2025

Same issue here. On version 19 and using the stock example from primeNG's website. onOpen and onClose are not getting triggered.

@benjaminforras
Copy link

Can confirm the same, we are currently blocked by this issue.

@osaf96
Copy link

osaf96 commented Feb 20, 2025

These events are not working. Anyone working on this issue?

@TarhanTech
Copy link
Contributor

Not wokring in my case either

@haesu
Copy link

haesu commented Feb 21, 2025

Is there a plan or timeframe to address and resolve it?

@TarhanTech
Copy link
Contributor

Is there a CONTRIBUTING.md file so I can fix this?

@TarhanTech
Copy link
Contributor

TarhanTech commented Feb 22, 2025

Created an PR for this:
#17748

@cetincakiroglu cetincakiroglu linked a pull request Feb 24, 2025 that will close this issue
@cetincakiroglu cetincakiroglu added this to the 19.0.8 milestone Feb 24, 2025
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Feb 24, 2025
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Feb 24, 2025
@github-project-automation github-project-automation bot moved this from Review to Done in PrimeNG Feb 24, 2025
@Smorgaz
Copy link

Smorgaz commented Feb 26, 2025

There seems to still be an issue with those emitted events. The emitted index is always -1 in our project. I'm currently using version 19.0.8

@gregorwinkler
Copy link

Can confirm, the emitted index is always -1 in our case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

10 participants